Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in get_frame_indices #389

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix bug in get_frame_indices #389

merged 3 commits into from
Nov 28, 2024

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Nov 27, 2024

Fix a bug that caused alphadia to stall at "candidate selection" in some cases.

introduced here https://github.com/MannLabs/alphadia/pull/374/files#diff-2f0dbd316d0891916239ef34b6362cdc39faa19711e337c80d0596356a10f82cR747-R749

also, upgrade alphabase to the latest 1.4.2 (we somehow missed that for 1.9.0)

@mschwoer mschwoer requested a review from GeorgWa November 27, 2024 11:37
@mschwoer mschwoer added the test:e2e End to end tests will be run on PRs that carry this label. label Nov 27, 2024
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mschwoer mschwoer requested a review from GeorgWa November 27, 2024 16:49
@mschwoer mschwoer added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Nov 27, 2024
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let’s ship 1.9.1

@mschwoer mschwoer changed the base branch from main to development November 28, 2024 08:36
@mschwoer mschwoer merged commit ad8bb4a into development Nov 28, 2024
28 checks passed
@mschwoer mschwoer deleted the fix_candidate_selection branch November 28, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants